[FLINK-33210] Introduce lineage graph relevant interfaces #23626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
KarmaGYZ
reviewed
Oct 31, 2023
Contributor
KarmaGYZ
left a comment
KarmaGYZ
left a comment
There was a problem hiding this comment.
Thanks for the PR. Will merge it after all the comments addressed.
...streaming-java/src/main/java/org/apache/flink/streaming/api/lineage/DefaultLineageGraph.java
Show resolved
Hide resolved
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/lineage/LineageGraphTest.java
Outdated
Show resolved
Hide resolved
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/lineage/LineageGraphTest.java
Outdated
Show resolved
Hide resolved
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/lineage/LineageGraphTest.java
Outdated
Show resolved
Hide resolved
KarmaGYZ
approved these changes
Nov 1, 2023
Contributor
Author
|
@flinkbot run azure |
JingGe
reviewed
Nov 20, 2023
Contributor
JingGe
left a comment
JingGe
left a comment
There was a problem hiding this comment.
Thanks for driving it! I just left some NIT comments
...streaming-java/src/main/java/org/apache/flink/streaming/api/lineage/DefaultLineageGraph.java
Outdated
Show resolved
Hide resolved
...streaming-java/src/main/java/org/apache/flink/streaming/api/lineage/DefaultLineageGraph.java
Outdated
Show resolved
Hide resolved
FangYongs
force-pushed
the
FLINK_33210_lineage_graph
branch
from
49e58e4 to
29dda59
Compare
Contributor
Author
|
Thanks @JingGe , please help to review this PR again |
Contributor
Author
|
@HuangZhenQiu @mobuchowski I have add dataset and facet interfaces in lineage vertex, please help to review this PR cc @X-czh |
FangYongs
force-pushed
the
FLINK_33210_lineage_graph
branch
from
29dda59 to
153eabb
Compare
X-czh
reviewed
Mar 4, 2024
...aming-java/src/test/java/org/apache/flink/streaming/api/lineage/DefaultLineageGraphTest.java
Outdated
Show resolved
Hide resolved
Contributor
|
@FangYongs Thanks for the PR. The changes LGTM except for a nit on the UT. |
FangYongs
force-pushed
the
FLINK_33210_lineage_graph
branch
from
153eabb to
99d146e
Compare
hanyuzheng7
pushed a commit
to hanyuzheng7/flink
that referenced
this pull request
May 6, 2024
* [FLINK-33210] Introduce lineage graph relevant interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR aims to add lineage graph relevant interfaces such as
LineageGraph,LineageVertex,SourceLineageVertexandLineageEdgeBrief change log
Verifying this change
This change added tests and can be verified as follows:
LineageGraphTestDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no) yesDocumentation